Skip to content

moved lookup of generic keyword parameters to declaration site of a constructor, such that it can be kept static and reused between field accesses #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2025
Merged

moved lookup of generic keyword parameters to declaration site of a constructor, such that it can be kept static and reused between field accesses #2417

merged 4 commits into from
Sep 24, 2025

Conversation

jurgenvinju
Copy link
Member

No description provided.

@jurgenvinju
moved lookup of generic keyword parameters to declaration site of a c…
baa36af 
…onstructor, such that it can be kept static and reused between field accesses
@jurgenvinju
Revert "moved lookup of generic keyword parameters to declaration sit…
ce70afe 
…e of a constructor, such that it can be kept static and reused between field accesses"

This reverts commit baa36af.
@jurgenvinju
added generic keyword parameter cache as an experiment
2811305
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47%. Comparing base (7e683c0) to head (beb2078).
⚠️ Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
...g/rascalmpl/interpreter/env/ModuleEnvironment.java 80% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              main   #2417   +/-   ##
=======================================
- Coverage       47%     47%   -1%     
- Complexity    6579    6590   +11     
=======================================
  Files          782     782           
  Lines        64531   64585   +54     
  Branches      9656    9663    +7     
=======================================
+ Hits         30561   30582   +21     
- Misses       31608   31640   +32     
- Partials      2362    2363    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DavyLandman
DavyLandman approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 1 have one line that I'm curious about.

@DavyLandman DavyLandman marked this pull request as ready for review September 24, 2025 10:32
@DavyLandman DavyLandman merged commit a284eef into main Sep 24, 2025
8 checks passed
@DavyLandman DavyLandman mentioned this pull request Sep 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavyLandman DavyLandman DavyLandman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jurgenvinju @DavyLandman